Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide correct FTL stats #1619

Merged
merged 3 commits into from Jul 25, 2017

Conversation

Projects
None yet
2 participants
@WaLLy3K
Copy link
Collaborator

WaLLy3K commented Jul 18, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


  • Use the correct lines in the array when displaying FTL stats
  • Treat ads_blocked_today/dns_queries_today as currency, like domains_being_blocked is on large screens

WaLLy3K added some commits Jul 18, 2017

Provide correct FTL stats
* Use the correct lines in the array when displaying FTL stats
* Treat ads_blocked_today/dns_queries_today as currency, like domains_being_blocked is on large screens

@WaLLy3K WaLLy3K added this to the v3.2 milestone Jul 20, 2017

@PromoFaux

This comment has been minimized.

Copy link
Member

PromoFaux commented Jul 25, 2017

Approved

Approved with PullApprove

@PromoFaux PromoFaux merged commit 714fd93 into development Jul 25, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by PromoFaux, WaLLy3K
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PromoFaux PromoFaux deleted the fix/chrono-ftlstats branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.