Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPN host names to local.list #1682

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@DL6ER
Copy link
Member

DL6ER commented Sep 6, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Parse /etc/openvpn/ipp.txt (if existing) and parse + add entries to local.list.

Fixes pi-hole/AdminLTE#569

This template was created based on the work of udemy-dl.

@Mcat12
Copy link
Member

Mcat12 left a comment

I don't have the setup to test, but LGTM

Simplify awk code as the format of ipp.txt is actually fixed (only on…
…e entry per line is allowed)

Signed-off-by: DL6ER <dl6er@dl6er.de>
@PromoFaux

This comment has been minimized.

Copy link
Member

PromoFaux commented Sep 8, 2017

Confirmed working

@PromoFaux

This comment has been minimized.

Copy link
Member

PromoFaux commented Sep 8, 2017

Approved

Approved with PullApprove

@DL6ER DL6ER merged commit 17be6b8 into development Sep 8, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by DL6ER, PromoFaux
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DL6ER DL6ER deleted the tweak/VPN_hostnames branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.