Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore-case switch to sort (domains) #1687

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@spacedingo
Copy link
Contributor

spacedingo commented Sep 8, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

3


Added "ignore-case" switch to the sort domains command, in gravity.sh
This is a bug fix. Duplicate domains are passed into the gravity list, if one of them contain any capitals. Like so:

::: /etc/pihole/list.preEventHorizon (2 results)
adsatt.abcnews.starwave.com
Adsatt.ABCNews.starwave.com

This template was created based on the work of udemy-dl.

Add ignore-case switch to sort (domains)
Domains with caps pass off as unique. It is necessary for proper duplicate removal.
Example:
::: /etc/pihole/list.preEventHorizon (2 results)
adsatt.abcnews.starwave.com
Adsatt.ABCNews.starwave.com

@spacedingo spacedingo referenced this pull request Sep 8, 2017

Closed

Make duplicate removal case insensitive #1658

5 of 5 tasks complete
@DL6ER

DL6ER approved these changes Sep 8, 2017

@Mcat12

Mcat12 approved these changes Sep 8, 2017

@Mcat12

Mcat12 approved these changes Sep 8, 2017

@DL6ER

DL6ER approved these changes Sep 8, 2017

@DL6ER DL6ER merged commit ca88c59 into pi-hole:development Sep 8, 2017

4 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by DL6ER, Mcat12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

spacedingo added a commit to spacedingo/pi-hole that referenced this pull request Sep 26, 2017

Redo pull pi-hole#1687
Fix for case sensitive duplicate domains
The change (pi-hole#1687) was recently undone.

@spacedingo spacedingo referenced this pull request Sep 26, 2017

Merged

Redo pull #1687 (case-sensitive duplicate fix) #1710

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.