Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add administrative contact address functionality #1691

Merged
merged 1 commit into from Sep 19, 2017

Conversation

Projects
None yet
3 participants
@WaLLy3K
Copy link
Collaborator

WaLLy3K commented Sep 14, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

9


The Block Page has functionality that checks setupVars.conf for an ADMIN_EMAIL variable. If set, it will display "ask the administrator" as a hyperlink to the defined email address.

Add administrative contact address functionality
* Disable shellcheck for SC1090
@PromoFaux

This comment has been minimized.

Copy link
Member

PromoFaux commented Sep 19, 2017

LGTM, Works as expected.

@WaLLy3K WaLLy3K merged commit f3cc8c7 into development Sep 19, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by PromoFaux, WaLLy3K
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@WaLLy3K WaLLy3K deleted the new/adminemail branch Sep 19, 2017

@WaLLy3K WaLLy3K referenced this pull request Sep 22, 2017

Closed

Add administrative contact address functionality #579

3 of 3 tasks complete

WaLLy3K added a commit that referenced this pull request Oct 8, 2017

Merge pull request #1729 from pi-hole/fix/email-help-argument
Allow emails which include `-h` in them (Fix for #1691)
@pralor

This comment has been minimized.

Copy link

pralor commented Feb 14, 2018

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/website-blocked-technical-info-email-notify-admin-option/7154/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.