Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start and enable FTL prior to running Gravity #1700

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
2 participants
@WaLLy3K
Copy link
Collaborator

WaLLy3K commented Sep 20, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

9


Currently, basic-install.sh performs the following:

  • Start dnsmasq
  • Enable dnsmasq on reboot
  • Start lighttpd
  • Enable lighttpd on reboot
  • Run gravity.sh
  • Start FTL
  • Enable FTL on reboot

In the potential event that Gravity fails (e.g: Internet is not available, or user hits Ctrl-C), the user is left with an installation where FTL is not active. This fix aims to resolve that by ensuring that gravity.sh runs after enabling FTL.

@PromoFaux

This comment has been minimized.

Copy link
Member

PromoFaux commented Sep 21, 2017

Approved

@PromoFaux PromoFaux merged commit 4316b15 into development Sep 21, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by PromoFaux, WaLLy3K
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PromoFaux PromoFaux deleted the fix/start-ftl branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.