New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease `local-ttl` to 2 #1701

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@WaLLy3K
Member

WaLLy3K commented Sep 21, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

9


Decrease `local-ttl` to 2
* Decreasing value should benefit clients when whitelisting blocked sites, [as per this discussion](#1698 (comment)).
@DL6ER

DL6ER approved these changes Sep 21, 2017

Tested, don't see any negative effect on a NanoPi NEO with stock blocking lists

@WaLLy3K

This comment has been minimized.

Member

WaLLy3K commented Sep 21, 2017

I've noticed an issue where on slower hardware with large blocklists (e.g: Pi Zero (class 6 Micro SD card) with 1.2M blocked domains), dnsmasq can take up to two minutes to be resolvable as /etc/pihole/gravity.list is still being read - this can result in an end user having their browser show that the DNS is unavailable, instead of the Block Page (and the notice which says that they should flush their DNS cache).

Altering local-ttl only exposes an issue that was already there, but more importantly, creates the benefit of a more seamless whitelisting experience for those with smaller lists and/or more powerful hardware.

With this in mind, I'm still merging this PR.

@WaLLy3K WaLLy3K merged commit 3bb05ed into development Sep 21, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by DL6ER, dschaper, WaLLy3K
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@WaLLy3K WaLLy3K deleted the fix/local-ttl branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment