New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in some exclusions for some files that shouldn't be web accessible. #1704

Merged
merged 3 commits into from Sep 23, 2017

Conversation

Projects
None yet
4 participants
@celly
Contributor

celly commented Sep 22, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • [馃ぁ] I have read and understood the contributors guide.
  • [馃ぁ] I have checked that another pull request for this purpose does not exist.
  • [馃ぁ] I have considered, and confirmed that this submission will be valuable to others.
  • [馃ぁ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [馃ぁ] I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

3.3

I noticed that the admin was leaking some files. In perfect world, these would be cleaned up, but keeping them does make debug and dev easier -- so, just adding in deny filters in lighttpd.

This template was created based on the work of udemy-dl.

@@ -66,5 +66,10 @@ $HTTP["url"] =~ "^/admin/" {
}
}
# Block the github files from being accessible.
$HTTP["url"] =~ "^/admin/(.git|.gitignore|.github)" {

This comment has been minimized.

@PromoFaux

PromoFaux Sep 22, 2017

Member

Maybe just any directory starting with a ., as those should not be relevant

@celly

This comment has been minimized.

Contributor

celly commented Sep 22, 2017

@PromoFaux Makes sense. Updated committed.

@Mcat12

Mcat12 approved these changes Sep 22, 2017

LGTM

@WaLLy3K

Good find, nice fix!

@WaLLy3K WaLLy3K merged commit f0f7bda into pi-hole:development Sep 23, 2017

4 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by Mcat12, WaLLy3K
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment