Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append ".vpn" TLD for OpenVPN host names #1718

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@DL6ER
Copy link
Member

DL6ER commented Sep 30, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


When using the Pi-hole DHCP server, local host names are augmented by the TLD .local.
This PR append host names of clients that are connected via VPN by a similar TLD ".vpn".

before:

echo ">client-names" | nc pi.hole 4711
0 2841 10.8.0.2 cuda
1 9329 127.0.0.1 localhost
2 1027 10.8.0.6 Thinkpad
3 322 192.168.2.2 android-phone.local
4 4142 192.168.2.3 desktop.local
5 638 192.168.2.5 android-tablet.local
6 914 192.168.2.4 desktop2.local
7 452 192.168.2.6 ThinkPad.local
---EOM---

With this PR:

echo ">client-names" | nc pi.hole 4711
0 2841 10.8.0.2 cuda.vpn
1 9329 127.0.0.1 localhost
2 1027 10.8.0.6 Thinkpad.vpn
3 322 192.168.2.2 android-phone.local
4 4142 192.168.2.3 desktop.local
5 638 192.168.2.5 android-tablet.local
6 914 192.168.2.4 desktop2.local
7 452 192.168.2.6 ThinkPad.local
---EOM---

This template was created based on the work of udemy-dl.

When using the Pi-hole DHCP server, local host names are called "some…
…thing.local". Thir PR ensures that clients that are connected via VPN are augmented by a similar suffix like "someother.vpn".

Signed-off-by: DL6ER <dl6er@dl6er.de>

@DL6ER DL6ER added the Enhancement label Sep 30, 2017

@Mcat12

Mcat12 approved these changes Oct 3, 2017

@DL6ER DL6ER merged commit 3578a3e into development Oct 3, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by DL6ER, Mcat12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DL6ER DL6ER deleted the tweak/VPNhostnames branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.