Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emails which include -h in them #1729

Merged
merged 2 commits into from Oct 8, 2017
Merged

Conversation

AzureMarker
Copy link
Contributor

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


For example, mcat12@pi-hole.net would previously spit out the help message.

This template was created based on the work of udemy-dl.

For example, mcat12@pi-hole.net would previously spit out the help message
@AzureMarker AzureMarker added the Bug: fixed Contains a bug resolution label Oct 7, 2017
Signed off by WaLLy3K <wally3k@pi-hole.net>
Copy link
Contributor

@WaLLy3K WaLLy3K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! I thought I already fixed this, but it must have been for a similar issue elsewhere that needed the help conditionals explicitly defined.

@WaLLy3K WaLLy3K merged commit d59a2a4 into development Oct 8, 2017
@WaLLy3K WaLLy3K deleted the fix/email-help-argument branch October 8, 2017 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: fixed Contains a bug resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants