Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passwords with spaces #1780

Merged
merged 10 commits into from Nov 24, 2017

Conversation

Projects
None yet
7 participants
@WaLLy3K
Copy link
Collaborator

WaLLy3K commented Nov 23, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

9


As reported here, a user can't create a Web Interface password with spaces in it.

Behaviour expected to work:

  • Either pihole -a -p foo bar or pihole -a -p "foo bar" will let you access the Web Interface with the password foo bar

Post-fix behaviour:

  • pihole -a -p "foo bar" allows you to access the Web interface with the password foo bar

Mausy5043 and others added some commits Nov 5, 2017

Merge pull request #1774 from mterron/patch-1
Add support for Quad9 secure dns server
Allow passwords with spaces
e.g: `pihole -a -p "foo bar"`

 Signed off by WaLLy3K <wally3k@pi-hole.net>

@WaLLy3K WaLLy3K added this to the v3.2 milestone Nov 23, 2017

@WaLLy3K WaLLy3K added the Bug: fixed label Nov 23, 2017

@DL6ER

DL6ER approved these changes Nov 23, 2017

Copy link
Member

DL6ER left a comment

This PR will also merge Quad9 servers to the release branch. Is this intended? If so -> Approved.

@jacobsalmela jacobsalmela self-requested a review Nov 24, 2017

@jacobsalmela jacobsalmela merged commit 90f01b5 into release/3.2 Nov 24, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by all reviewer groups.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@ion-storm

This comment has been minimized.

Copy link

ion-storm commented on eb9c44a Nov 25, 2017

https://news.ycombinator.com/item?id=15715318
Please add:
149.112.112.112 - blocking, no edns (same setup/config as 9.9.9.9)

This comment has been minimized.

Copy link
Member

Mcat12 replied Nov 25, 2017

See #1778

@WaLLy3K WaLLy3K deleted the fix/spacepasswd branch Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.