Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customfield_class customfield_tag are broken #201

Closed
amirhabibi opened this issue Aug 12, 2016 · 4 comments

Comments

@amirhabibi
Copy link

commented Aug 12, 2016

Hi !

These functions (used by shortcode) are broken in the latest version :

[catlist name="evenement" customfield_display_name="no" customfield_orderby=date numberposts=5 customfield_display=date customfield_class=css customfield_tag=span]

Errors :

Notice: Undefined variable: css_class in /..../wp-content/plugins/list-category-posts/include/lcp-catlistdisplayer.php on line 411

Notice: Undefined variable: tag in /..../wp-content/plugins/list-category-posts/include/lcp-catlistdisplayer.php on line 411

In the generated code :

Just the custom field content, not even the default DIV or css class

Thanks :)

@vacuus

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2016

Hey, I think I solved this. The get_custom_fields function was only assigning a value to $tag or $css_class if the params key mapped to an empty or null value. I'll create a pull request.

EDIT: Here's the change needed in case you need this solved right now: f4831bf .

@amirhabibi

This comment has been minimized.

Copy link
Author

commented Aug 16, 2016

Thanks a lot @vacuus !! I'll wait the new version. I don't wan't to mod the plugin.

@picandocodigo

This comment has been minimized.

Copy link
Owner

commented Sep 14, 2016

@amirhabibi this should be fixed in version 0.70 thanks to @vacuus. Please update and let me know if we can close this issue.

@zymeth25

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2018

Can be closed. Fixed in #202 . Issue not present now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.