Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple index space grid operator apply #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sslattery
Copy link
Collaborator

This pull request adds a version of apply() to the GridOperator which will thread over a user-specified set of index spaces. It uses the multiple index space version of Cajita::grid_parallel_for to accomplish this and therefore passes the user an additional index indicating which index space is currently active. This will be very useful for implementing boundary conditions or custom loop structures over subsets of the domain.

@sslattery sslattery added the enhancement New feature or request label Jun 24, 2021
@sslattery sslattery requested a review from terwin June 24, 2021 21:41
@sslattery sslattery self-assigned this Jun 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #35 (695560a) into master (752bebb) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   92.95%   93.10%   +0.14%     
==========================================
  Files          43       43              
  Lines        4129     4175      +46     
==========================================
+ Hits         3838     3887      +49     
+ Misses        291      288       -3     
Impacted Files Coverage Δ
src/Picasso_GridOperator.hpp 100.00% <100.00%> (ø)
unit_test/tstGridOperator2d.hpp 98.64% <100.00%> (+2.28%) ⬆️
unit_test/tstGridOperator3d.hpp 99.02% <100.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752bebb...695560a. Read the comment docs.

@terwin
Copy link
Collaborator

terwin commented Jun 25, 2021

It would be nice to have a test that uses multiple index spaces.

@sslattery sslattery closed this Aug 18, 2021
@sslattery sslattery reopened this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants