Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy 1.7.1 #905

Merged
merged 27 commits into from
Nov 30, 2023
Merged

Mypy 1.7.1 #905

merged 27 commits into from
Nov 30, 2023

Conversation

dantownsend
Copy link
Member

@dantownsend dantownsend commented Nov 29, 2023

When upgrading to the latest Mypy and Pylance, quite a few type errors were reported.

This PR fixes any type errors reported by the latest MyPy.

There should be overlap with Pylance (which seems even stricter than Mypy now), but will fix those in a separate PR.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (5f972d0) 92.09% compared to head (355208f) 92.03%.

Files Patch % Lines
piccolo/apps/migrations/auto/schema_differ.py 16.66% 5 Missing ⚠️
piccolo/apps/schema/commands/generate.py 28.57% 5 Missing ⚠️
piccolo/utils/pydantic.py 66.66% 2 Missing ⚠️
piccolo/apps/sql_shell/commands/run.py 90.90% 1 Missing ⚠️
piccolo/conf/apps.py 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   92.09%   92.03%   -0.07%     
==========================================
  Files         107      107              
  Lines        8126     8145      +19     
==========================================
+ Hits         7484     7496      +12     
- Misses        642      649       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend dantownsend changed the title Mypy 1.6.1 Mypy 1.7.1 Nov 30, 2023
@dantownsend dantownsend marked this pull request as ready for review November 30, 2023 12:52
@dantownsend dantownsend merged commit b8026da into master Nov 30, 2023
46 checks passed
@dantownsend dantownsend mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants