Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incognito mode is broken swift #320

Closed
tpfwrz opened this issue Apr 10, 2020 · 2 comments
Closed

incognito mode is broken swift #320

tpfwrz opened this issue Apr 10, 2020 · 2 comments

Comments

@tpfwrz
Copy link

tpfwrz commented Apr 10, 2020

incognito mode sets

configuration.websiteDataStore = WKWebsiteDataStore.nonPersistent()

This feature from apple allows you to run multiple webviews independent of shared cookies that only exist in memory.

However, this feature is completely broken due to a bug with swift.

When you initalize a webview with no websiteDataStore property, if you try to change it to noPersistent later it won't work.

The way this codebase works is when InAppWebview is created, init() creates a webview with no default options, thus doing exactly as the bug suggests.

I have modified the codebase and almost got it working correctly for myself, but there is another issue such as the actual options are nil within init so you kind of have to just set one and hope the other persists if you want to change it later.

@pichillilorenzo
Copy link
Owner

Could you explain it more? What bug? Which part of the code did you change? Thanks!

@pichillilorenzo
Copy link
Owner

New version 3.3.0+3 released!

This was referenced Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants