Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Responsive design improvement suggestion #74

Open
ptolp opened this Issue Jul 24, 2012 · 0 comments

Comments

Projects
None yet
1 participant

ptolp commented Jul 24, 2012

I'm planning to use your great jQuery plugin for a web service which uses RWD pattern. Guiders would work greatly for with just a few changes to JS code:

Change parameter

width: 400,

to

width: "400px",
maxWidth: "80%",

Then change

myGuider.elem.css("width", myGuider.width + "px");

to

myGuider.elem.css("width", myGuider.width);
myGuider.elem.css("maxWidth", myGuider.maxWidth);

This should do it. Now guiders are newer wider than viewport.
Why should the width have also unit? Because it allows using e.g. "20em" instead of pixels, which ensures good text legibility.

Additionally, images inside a guider can be forced to fit to the width of guider in the CSS file with

.guider_content img {max-width:100%}

But IMO this could also be left to developer to choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment