Make guiders attach to window object more reliably #79

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

spmason commented Dec 20, 2012

This fix ensures that the guiders object attaches to window correctly in more cases.

Previously if a build tool such as require.js wrapped the guiders.js contents in a closure then the "guiders" object would not be available outside that closure

Make guiders attach to window object more reliably
This fix ensures that the guiders object attaches to window correctly in more cases.

Previously if a build tool such as require.js wrapped the guiders.js contents in a closure then the "guiders" object would not be available outside that closure

Interesting, makes sense! I am not pulling this because I don't want to change the main branch, but am including this while working on the new version (2.0.0)

Owner

pickhardt commented Jan 27, 2013

Closing this because it is in the new version (2.0.0) that I am working on. I will push the changes to the new dev branch later tonight.

@pickhardt pickhardt closed this Jan 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment