fixed keydown event namespace #90

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@jbarata
jbarata commented Feb 7, 2013

without a proper namespace, the keydown event was being unbinded of every elemnt in the page and those stopped working. For example, it was unbinding existing shortcuts in the page where we are using js-shortcuts lib

@jbarata jbarata fixed keydown event namespace
without a proper namespace, the keydown event was being unbinded of every elemnt in the page and those stopped working. For example, it was unbinding existing shortcuts in the page (using Shortcuts.Js lib)
5cae876
@pickhardt
Owner

Thanks! I'll include this in the next version.

Jeff Pickhardt
pickhardt@gmail.com

On Thu, Feb 7, 2013 at 7:28 AM, Joao Barata notifications@github.comwrote:

without a proper namespace, the keydown event was being unbinded of every
elemnt in the page and those stopped working. For example, it was unbinding

existing shortcuts in the page where we are using js-shortcuts lib

You can merge this Pull Request by running

git pull https://github.com/cob/Guiders-JS fix_keydown_binding_namespace

Or view, comment on, or merge it at:

#90
Commit Summary

  • fixed keydown event namespace

File Changes

  • M guiders-1.3.0.jshttps://github.com/jeff-optimizely/Guiders-JS/pull/90/files#diff-0(6)

Patch Links:

@jbarata
jbarata commented Feb 8, 2013

You're welcome!

PS. and thank you for sharing this very nice component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment