New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Try out a different MarkDown provider for the HTML output format #269

Open
dirkrombauts opened this Issue Jan 22, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@dirkrombauts
Member

dirkrombauts commented Jan 22, 2016

Try out Strike.Jint.Merged as the MarkDown provider, so that we can optionally enable GitHub Flavored Markdown later.

  • Add it to the code.
  • Make sure the unit tests are still passing
  • Generate sample outputs for Html, and compare them to the sample output on the pickles website.
@dirkrombauts

This comment has been minimized.

Member

dirkrombauts commented Jan 22, 2016

@dstj would you have time to take a stab at this?

@dirkrombauts dirkrombauts changed the title from Spike: Try out a different MarkDown provider to Spike: Try out a different MarkDown provider for the HTML output format Jan 22, 2016

@dstj

This comment has been minimized.

dstj commented Jan 22, 2016

Hi Dirk, it won't be possible in the next few days/weeks,but I'll try to see if I can make up some time to try it out in a consistent manner. I'll like to avoid having my own separate custom fork for that...

@dirkrombauts

This comment has been minimized.

Member

dirkrombauts commented Mar 15, 2016

@dstj I'm playing around with this but I'm running into problems. Did you ever use Strike/markdownify in the static HTML version or only in the dynamic html version?

It works for me in the dynamic html version but in the static html version my own code is unhappy about <img> elements not being selfclosed.

@dstj

This comment has been minimized.

dstj commented Mar 18, 2016

@dirkrombauts, I am unsure I understand your question, I don't recall seeing a dynamic or static option. My usage was very simplistic. I used it to transform Markdown file to HTML and the only code I need was:

public class MarkdownifyProvider : IMarkdownProvider
    {
        private readonly Markdownify markdownify;

        public MarkdownifyProvider()
        {
            this.markdownify = new Markdownify();
        }

        public string Transform(string text)
        {
            var transform = markdownify.Transform(text);
            transform = transform.Replace("&nbsp;", string.Empty);
            return transform;
        }
    }
@dirkrombauts

This comment has been minimized.

Member

dirkrombauts commented Mar 18, 2016

@dstj no problem, I found the solution for my problem. In fact there was no problem in Markdownify but rather in its documentation.

@dirkrombauts

This comment has been minimized.

Member

dirkrombauts commented Mar 21, 2016

Released as an experimental feature in version 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment