New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build fail for server and agent #17

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
2 participants
@TokinRing
Collaborator

TokinRing commented Jul 2, 2017

I noticed that this problem was referred in issue #15 and was told that ignoring this fail is safe. The error references an old version of microtime that needed node-waf to build (which has been succeeded by node-gyp). I did the following to track down which package was breaking the build due to dependency failure to find that socket was the culprit. After removing socket from both server and agent package.json files, npm install builds without failure.

  • Show node depency tree:
npm ls
  • Got the following truncated output:
+-- request-debug@0.2.0
| `-- stringify-clone@1.1.1
+-- UNMET DEPENDENCY socket@
`-- sys@0.0.1

I also removed exec since its succeeded by child_process.execFile anyway.

Now you can close issue #15 for reals :p

@rusher81572 rusher81572 merged commit eef0355 into picluster:master Jul 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment