Typos and grammar issues on website #126

Closed
brendacs opened this Issue Dec 27, 2016 · 4 comments

Projects

None yet

2 participants

@brendacs
Contributor

I was reading about Picnic on the website at http://picnicss.com/ and I noticed there are a lot of minor grammar issues and no space before "terms and condition" (see screenshot below). It's just little things, but I think presentation matters.

image

I'd love to help fix these little issues since I'm just starting to try my hand at contributing to open source projects; I think these little things are a good place for me to start, and I'm very interested in this project!

@franciscop
Member

Sure! I think spacing issues come from migrating to Jade and then Pug (did I migrate to Pug?) and my editor.

@brendacs
Contributor

I see what you mean about the spacing issue.

Also, some fixes to grammar seem to have been made three days ago, but they just don't appear on the website because they haven't been migrated to the index.html. How would we do this (or would you handle it later on)?

@brendacs brendacs added a commit to brendacs/picnic that referenced this issue Dec 27, 2016
@brendacs brendacs Fix minor grammar issues for #126 5d4dc0d
@franciscop
Member

For minor fixes (missing an 's) I would just wait until the next small update, but since you batched few of them I just recompiled it and updated it.

If you want to go that extra step, you'd need to run grunt and it will create the proper HTML. Then I still need to pull from here and push to two Github Repositories (two different PR's to each wouldn't work).

Thank you for the fixes!

@franciscop franciscop closed this Dec 29, 2016
@brendacs
Contributor

Ah, I see. Thank you for explaining and no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment