Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Request] Do not use hgroup #90

Closed
AmiralBl3ndic opened this issue Dec 29, 2021 · 1 comment · Fixed by #94
Closed

[Change Request] Do not use hgroup #90

AmiralBl3ndic opened this issue Dec 29, 2021 · 1 comment · Fixed by #94

Comments

@AmiralBl3ndic
Copy link
Contributor

Hello.
First of all, thanks for the amazing product, it is a breeze to use for prototyping applications!

I am using the hgroup tag for grouping heading tags together as explained in the documentation but something bugs me: hgroup is not an HTML5 standard.
This is problematic because it makes using it very complicated with Vuejs for example: using hgroup with Vue + Vite results in build errors (TS2604).

Maybe for this specific use case it could be better of using non purely semantic but instead relying on classes?

i.e., this:

<hgroup>
    <h1>Hello</h1>
    <h2>World</h2>
</hgroup>

could become this:

<div class="headings">
    <h1>Hello</h1>
    <h2>World</h2>
</div>

Thanks again! 🚀

@lucaslarroche
Copy link
Member

lucaslarroche commented Dec 31, 2021

Also solves #32

@lucaslarroche lucaslarroche linked a pull request Dec 31, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants