tinyiconv: Add a small iconv implementation#930
Merged
keith-packard merged 2 commits intomainfrom Jan 29, 2025
Merged
Conversation
keith-packard
force-pushed
the
tiny-iconv
branch
3 times, most recently
from
5293d08 to
ec2c6d6
Compare
We need to cast values to wchar_t before shifting so they don't get sign-extended to negative values during the implicit conversion from 16-bit int to 32-bit wchar_t. Signed-off-by: Keith Packard <keithp@keithp.com>
This uses the existing multibyte transcoding support rather than implementing a completely separate mechanism. As such, it always supports the charsets provided by that code and so doesn't require separate configuration bits. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
tiny-iconv
branch
from
ec2c6d6 to
8a8b9a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the existing multibyte transcoding support rather than implementing a completely separate mechanism. As such, it always supports the charsets provided by that code and so doesn't require separate configuration bits.