Add Telepen/Telepen Numeric #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor corrections to construction, and comments
src/Types/TypeTelepen.php
Outdated
Comment on lines
22
to
25
| define('TELEPEN_START_CHAR', '_'); | ||
| define('TELEPEN_STOP_CHAR', 'z'); | ||
| define('TELEPEN_ALPHA', 'alpha'); | ||
| define('TELEPEN_NUMERIC', 'numeric'); |
There was a problem hiding this comment.
I don't like these broad define's in de codebase. I think these can be private constants in the class itself, so it is encapsuled from the rest of the application.
There was a problem hiding this comment.
changed to const
|
|
||
| private function createTelepenConversionTable() | ||
| { | ||
| $this->telepen_lookup_table = [ |
There was a problem hiding this comment.
Can this be formatted better? Can you also provide a comment about how this lookup table works?
There was a problem hiding this comment.
Small amount of explanation added to table creation, and grouped items into consistent rows of 4 items
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Telepen / Telepen numeric codes