Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken typescript typings #104

Open
NaridaL opened this issue Jul 20, 2017 · 1 comment
Open

Broken typescript typings #104

NaridaL opened this issue Jul 20, 2017 · 1 comment
Assignees

Comments

@NaridaL
Copy link

NaridaL commented Jul 20, 2017

The TS typings currently add stuff to the global scope, they should use something like http://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-function-d-ts.html so they work both in a browser env and when importing them as modules. Also add the typings to the "typings" field of the package.json so TS finds them when importing.

@pid
Copy link
Owner

pid commented Jul 25, 2017

@stonio can you take a look on it?

@pid pid self-assigned this Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants