-
Notifications
You must be signed in to change notification settings - Fork 566
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Optimization of Base64 and URISafe compression and decompression meth…
…ods. This breaks the binary compatibility of the compression, meaning the same string can have a different compressed base64 version. Both the new and the old versions of the library are able to decompress both compressed versions though. The tests have been updated accordingly.
- Loading branch information
Showing
2 changed files
with
48 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2d5a419
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, pre-existing compressed data held as UTF-16 in localStorage on several thousand devices will still be decompressed accurately?
2d5a419
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's binary compatible for decompression (both ascending and descending). Note that this is a pre-release yet and performances are a bit odd on IE where this stuff is slower than the latest version, but I don't have much data yet. Can you pass the jsperf with all the IEs you have at hand?
https://github.com/pieroxy/lz-string/releases/tag/1.4.0-beta
2d5a419
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use IE. Chrome/Safari only. We are browser nazis to our clients.