Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements are not automatically installed when running a pip install #41

Closed
arokem opened this issue May 24, 2021 · 1 comment · Fixed by #42
Closed

Requirements are not automatically installed when running a pip install #41

arokem opened this issue May 24, 2021 · 1 comment · Fixed by #42

Comments

@arokem
Copy link
Contributor

arokem commented May 24, 2021

When installing into a Docker image, we get:

Python 3.8.10 (default, May 12 2021, 15:46:43) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import picard
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/picard/__init__.py", line 23, in <module>
    from .dropin_sklearn import Picard  # noqa
  File "/usr/local/lib/python3.8/site-packages/picard/dropin_sklearn.py", line 10, in <module>
    from sklearn.decomposition import FastICA
ModuleNotFoundError: No module named 'sklearn'

I think that's because the setup.py doesn't have a "requires" section, but not sure.

@pierreablin
Copy link
Owner

pierreablin commented May 24, 2021

Thanks ! See #42 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants