From 5340ffac369f404b5a0397dafbfd2a9ff3053861 Mon Sep 17 00:00:00 2001 From: Amadeus Demarzi Date: Tue, 5 May 2026 12:06:39 -0700 Subject: [PATCH] Fix getTopForItem API It was not including paddingTop which was causing some issues... --- packages/diffs/src/components/CodeView.ts | 6 +++--- packages/diffs/src/components/VirtualizedFile.ts | 2 +- packages/diffs/src/components/VirtualizedFileDiff.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/diffs/src/components/CodeView.ts b/packages/diffs/src/components/CodeView.ts index 92b3808f5..6eb42c3ec 100644 --- a/packages/diffs/src/components/CodeView.ts +++ b/packages/diffs/src/components/CodeView.ts @@ -981,13 +981,13 @@ export class CodeView { }; } - public getTopForInstance( + public getLocalTopForInstance( instance: VirtualizedFile | VirtualizedFileDiff ): number { const item = this.instanceToItem.get(instance); if (item == null) { throw new Error( - 'CodeView.getTopForInstance: unknown virtualized instance' + 'CodeView.getLocalTopForInstance: unknown virtualized instance' ); } return item.top; @@ -998,7 +998,7 @@ export class CodeView { if (item == null) { return undefined; } - return item.top; + return item.top + this.getViewerMetrics().paddingTop; } private createItem( diff --git a/packages/diffs/src/components/VirtualizedFile.ts b/packages/diffs/src/components/VirtualizedFile.ts index 54c4c61d3..bbcae69b6 100644 --- a/packages/diffs/src/components/VirtualizedFile.ts +++ b/packages/diffs/src/components/VirtualizedFile.ts @@ -616,7 +616,7 @@ export class VirtualizedFile< private getVirtualizedTop(): number { if (this.virtualizer.type === 'advanced') { - return this.virtualizer.getTopForInstance(this); + return this.virtualizer.getLocalTopForInstance(this); } return this.fileContainer != null ? this.virtualizer.getOffsetInScrollContainer(this.fileContainer) diff --git a/packages/diffs/src/components/VirtualizedFileDiff.ts b/packages/diffs/src/components/VirtualizedFileDiff.ts index c805f9643..9db5e11b3 100644 --- a/packages/diffs/src/components/VirtualizedFileDiff.ts +++ b/packages/diffs/src/components/VirtualizedFileDiff.ts @@ -763,7 +763,7 @@ export class VirtualizedFileDiff< private getVirtualizedTop(): number | undefined { if (this.virtualizer.type === 'advanced') { - return this.virtualizer.getTopForInstance(this); + return this.virtualizer.getLocalTopForInstance(this); } return this.fileContainer != null ? this.virtualizer.getOffsetInScrollContainer(this.fileContainer)