Permalink
Browse files

GitIndex: Fix a few comments

  • Loading branch information...
1 parent 029b42c commit 59d4a159a47945543398599f70d7de2db1e0a7cd @pieter committed Sep 13, 2009
Showing with 3 additions and 5 deletions.
  1. +3 −5 PBGitIndex.m
View
@@ -142,6 +142,7 @@ - (NSString *) parentTree
return parent;
}
+// TODO: make Asynchronous
- (void)commitWithMessage:(NSString *)commitMessage
{
NSMutableString *commitSubject = [@"commit: " mutableCopy];
@@ -419,8 +420,7 @@ - (void)readOtherFiles:(NSNotification *)notification
NSArray *lines = [self linesFromNotification:notification];
NSMutableDictionary *dictionary = [[NSMutableDictionary alloc] initWithCapacity:[lines count]];
// Other files are untracked, so we don't have any real index information. Instead, we can just fake it.
- // The line below is used to add the file to the index
- // FIXME: request the real file mode
+ // The line below is not used at all, as for these files the commitBlob isn't set
NSArray *fileStatus = [NSArray arrayWithObjects:@":000000", @"100644", @"0000000000000000000000000000000000000000", @"0000000000000000000000000000000000000000", @"A", nil];
for (NSString *path in lines) {
if ([path length] == 0)
@@ -450,7 +450,6 @@ - (void) readUnstagedFiles:(NSNotification *)notification
- (void) addFilesFromDictionary:(NSMutableDictionary *)dictionary staged:(BOOL)staged tracked:(BOOL)tracked
{
- // TODO: Stop tracking files
// Iterate over all existing files
for (PBChangedFile *file in files) {
NSArray *fileStatus = [dictionary objectForKey:file.path];
@@ -494,7 +493,6 @@ - (void) addFilesFromDictionary:(NSMutableDictionary *)dictionary staged:(BOOL)s
file.hasUnstagedChanges = NO;
}
}
- // TODO: Finish tracking files
// Do new files only if necessary
if (![[dictionary allKeys] count])
@@ -535,7 +533,7 @@ - (NSArray *)linesFromNotification:(NSNotification *)notification
return [NSArray array];
NSString *string = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
- // FIXME: Return an error?
+ // FIXME: throw an error?
if (!string)
return [NSArray array];

0 comments on commit 59d4a15

Please sign in to comment.