New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging support #1

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@zyegfryed
Contributor

zyegfryed commented Aug 8, 2018

Hi,
This PR aims to add packaging support to the elasticsearch_upgrade.py script so it can be installed via pip. Once installed, the elasticsearch-upgrade binary is available into the environment. It also fix some flake8-related issue.
Cheers

@pietervogelaar

This comment has been minimized.

Show comment
Hide comment
@pietervogelaar

pietervogelaar Aug 14, 2018

Owner

Thanks for you contribution. Please only add the functionality that is related to add packaging support. This pull request changed a whole lot of formatting.

Owner

pietervogelaar commented Aug 14, 2018

Thanks for you contribution. Please only add the functionality that is related to add packaging support. This pull request changed a whole lot of formatting.

@zyegfryed

This comment has been minimized.

Show comment
Hide comment
@zyegfryed

zyegfryed Aug 14, 2018

Contributor

@pietervogelaar I ditched the formatting commit as requested.

Contributor

zyegfryed commented Aug 14, 2018

@pietervogelaar I ditched the formatting commit as requested.

@pietervogelaar

Thanks!

@pietervogelaar pietervogelaar merged commit 585a9c0 into pietervogelaar:master Aug 14, 2018

@pietervogelaar

This comment has been minimized.

Show comment
Hide comment
@pietervogelaar

pietervogelaar Aug 14, 2018

Owner

@zyegfryed Are you willing to create/maintain the official python pip package for it?

Owner

pietervogelaar commented on f61369e Aug 14, 2018

@zyegfryed Are you willing to create/maintain the official python pip package for it?

This comment has been minimized.

Show comment
Hide comment
@zyegfryed

zyegfryed Aug 15, 2018

Contributor

@pietervogelaar Sure, I can do it if you want. It's as easy as: python setup.py sdist bdist_wheel && twine upload dist/*

Contributor

zyegfryed replied Aug 15, 2018

@pietervogelaar Sure, I can do it if you want. It's as easy as: python setup.py sdist bdist_wheel && twine upload dist/*

@zyegfryed

This comment has been minimized.

Show comment
Hide comment
@zyegfryed

zyegfryed Aug 15, 2018

Contributor

Actually, I made a mistake: I forgot to use a proper package layout structure :( I'll open another PR to fix it.

Contributor

zyegfryed commented Aug 15, 2018

Actually, I made a mistake: I forgot to use a proper package layout structure :( I'll open another PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment