New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simple coverage report #9
Conversation
Can no longer reproduce issue locally, trying to make the entire method synchronized
Pipeline consistently fails with |
The issue was that my branch had an outdated Exception definition. That was fine locally but the pipeline used the remote definition since that would be the end result of the merge and thus kept failing. Moral of the story; always merge the remote branch to your branch before making a pull request. |
Codecov Report
@@ Coverage Diff @@
## dev #9 +/- ##
======================================
Coverage ? 66.66%
======================================
Files ? 1
Lines ? 45
Branches ? 0
======================================
Hits ? 30
Misses ? 15
Partials ? 0 Continue to review full report at Codecov.
|
gamer |
Main Changes
Added a simple coverage report that shows you how many times each
Expr
case class is used in the tests.The output currently looks ugly, in the future I'll look into the possibility of using CodeCov.
Edit
Turns out adding CodeCov was a lot less complicated than what I was expecting so I did that.
The coverage is no longer printed in the console as shown in the picture earlier (although it is easy to add it back if that is wanted, see here).
The Coverage class now also associates the covered classes with their respective lines in the
Definitions.scala
file meaning you can now get clean detailed views. Currently, "low" coverages won't fail a pipeline but that along with other stuff like what is considered "low" coverage can be changed from thecodecov.yml
file.The coverage report is a bit weird now because the base (source repo) does not have any reports yet but that should fix itself post-merge. Link to the CodeCov report.
Also epic badge
[![codecov](https://codecov.io/gh/pijuskri/Po-Sharp/branch/dev/graph/badge.svg)](https://codecov.io/gh/pijuskri/Po-Sharp/)
.Other
As noted in the documentation, any
Expr
case class can be omitted from the coverage results if it is considered unimportant.The pull request also includes: