Test mpi_ring_async_sender_receiver with all MPI completion modes
#1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
force-pushed
the
mpi-ring-test-all-modes
branch
2 times, most recently
from
6907577
to
b7b5615
Compare
biddisco
requested changes
Jun 7, 2024
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
biddisco
reviewed
Jun 7, 2024
biddisco
approved these changes
Jun 7, 2024
Merged
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
…ync_sender_receiver test
… suspend_resume mode
Two counters were used for debugging during development, but are not really needed for counting tasks in flight and it's better to use the main in_flight counter for checking when finished.
msimberg
force-pushed
the
mpi-ring-test-all-modes
branch
from
cf04418
to
13e41fe
Compare
biddisco
approved these changes
Jun 25, 2024
msimberg
force-pushed
the
mpi-ring-test-all-modes
branch
from
abb60e5
to
d06f114
Compare
This avoids data races between writing (set_max_polling_size) and reading (within the MPI polling loop) the max polling size. Reads are relaxed since we don't care much about stale values being used.
msimberg
force-pushed
the
mpi-ring-test-all-modes
branch
from
d06f114
to
61555e4
Compare
|
Is this PR good to go now? |
Yes, should be. I was hoping to get CSCS CI back for testing before merging it. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142, except for testing the MPI continuations modes. Those will be enabled separately (#1150).
This:
--pika:mpi-completion-modeflag for setting the mode via command line options. This isn't intended as the primary way to change the mode for users, but is mostly there for the unit test. CMake'sENVIRONMENTproperty on tests allows setting an environment variable. I originally intended to use this, but the variables are not exported so sub-processes don't see the value, and since the tests are run throughmpirun/mpiexecthe variable isn't applied.PIKA_TEST_EQso that it's run with all build types and prints the failing value if it fails.--recv-before-sendflag to the unit test, and makes send-before-recv the default, to avoid deadlocks when requests are done inline. Sends will never block indefinitely, so doing the sends first avoids hangs.