Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up version module #166

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Clean up version module #166

merged 3 commits into from
Apr 7, 2022

Conversation

aurianer
Copy link
Contributor

Part of #16. Removes hwloc, boost and mpi dependency in the version module.

@aurianer aurianer added the effort: 1 You should probably just have done this instead of opening an issue... label Mar 31, 2022
@aurianer aurianer added this to the 0.3.0 milestone Mar 31, 2022
@aurianer aurianer requested a review from msimberg as a code owner March 31, 2022 14:31
@aurianer aurianer mentioned this pull request Mar 31, 2022
Open
59 tasks
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)++

Info

PropertyBeforeAfter
pika Commit01e4980e2184ca113b853ae3a36869f713fcc4b96f01758
pika Datetime2021-12-21T15:01:46+00:002022-03-31T15:17:58+00:00
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid00932nid00004
Clusternamedaintdaint
Datetime2021-12-21T16:09:15.238666+01:002022-03-31T17:32:15.797563+02:00
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
pika Commitf499a2233385060b8a2612ab88163e62b08818886f01758
pika Datetime2021-12-10T13:50:04+00:002022-03-31T15:17:58+00:00
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid00243nid00004
Clusternamedaintdaint
Datetime2021-12-10T15:19:42.442217+01:002022-03-31T17:32:32.613370+02:00
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add--(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitf64fbd02165a132a6276cedd14c586910abb79e46f01758
pika Datetime2021-11-12T11:29:27+00:002022-03-31T15:17:58+00:00
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid00007nid00004
Clusternamedaintdaint
Datetime2021-11-12T12:57:50.824026+01:002022-03-31T17:32:47.164760+02:00
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

msimberg
msimberg requested changes Apr 1, 2022
View reviewed changes
libs/pika/version/include/pika/version.hpp Outdated Show resolved Hide resolved
libs/pika/version/include/pika/version.hpp Outdated Show resolved Hide resolved
libs/pika/version/include/pika/version.hpp Outdated Show resolved Hide resolved
libs/pika/version/src/version.cpp Show resolved Hide resolved
@msimberg
Copy link
Contributor

msimberg commented Apr 1, 2022

test cscs

@aurianer aurianer removed the effort: 1 You should probably just have done this instead of opening an issue... label Apr 4, 2022
@msimberg msimberg modified the milestones: 0.3.0, 0.4.0 Apr 5, 2022
@pika-bot
Copy link
Collaborator

pika-bot commented Apr 6, 2022

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)+

Info

PropertyBeforeAfter
pika Commit01e4980e2184ca113b853ae3a36869f713fcc4b949704f9
pika Datetime2021-12-21T15:01:46+00:002022-04-06T13:58:07+00:00
Datetime2021-12-21T16:09:15.238666+01:002022-04-06T16:06:01.222543+02:00
Hostnamenid00932nid01193
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
pika Commitf499a2233385060b8a2612ab88163e62b088188849704f9
pika Datetime2021-12-10T13:50:04+00:002022-04-06T13:58:07+00:00
Datetime2021-12-10T15:19:42.442217+01:002022-04-06T16:06:18.018166+02:00
Hostnamenid00243nid01193
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add--(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
pika Commitf64fbd02165a132a6276cedd14c586910abb79e449704f9
pika Datetime2021-11-12T11:29:27+00:002022-04-06T13:58:07+00:00
Datetime2021-11-12T12:57:50.824026+01:002022-04-06T16:06:32.463964+02:00
Hostnamenid00007nid01193
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor

msimberg commented Apr 6, 2022

test cscs

msimberg
msimberg approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@aurianer
Copy link
Contributor Author

aurianer commented Apr 6, 2022

test cscs

@msimberg
Copy link
Contributor

msimberg commented Apr 7, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 7, 2022

Build succeeded:

@bors bors bot merged commit 0d4ed80 into pika-org:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

Assignees

@aurianer aurianer

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @pika-bot @msimberg