New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default socket connection timeout to 10s #1007

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
3 participants
@michaelklishin
Contributor

michaelklishin commented Mar 27, 2018

0.25s is too optimistic a default.

Closes #995.

Bump default socket connection timeout to 10s
0.25s is too optimistic a default.

Closes #995.
@codecov

This comment has been minimized.

codecov bot commented Mar 27, 2018

Codecov Report

Merging #1007 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1007   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          19       19           
  Lines        3775     3775           
  Branches      563      563           
=======================================
  Hits         3139     3139           
  Misses        481      481           
  Partials      155      155
Impacted Files Coverage Δ
pika/connection.py 86.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3baa4...0e4acb8. Read the comment docs.

@lukebakken lukebakken added this to the 1.0.0 milestone Mar 28, 2018

@lukebakken lukebakken merged commit 132cea5 into master Mar 28, 2018

6 checks passed

codecov/patch 100% of diff hit (target 83.15%)
Details
codecov/project 83.15% (+0%) compared to 3a3baa4
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukebakken lukebakken deleted the pika-995 branch Mar 28, 2018

@vitaly-krugl

LGTM, belatedly 👍

lukebakken added a commit that referenced this pull request Apr 13, 2018

Merge pull request #1007 from pika/pika-995
Bump default socket connection timeout to 10s

(cherry picked from commit 132cea5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment