Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
pika: Don't automatically import twisted and tornado. #1129
Previously, the pika.adapters convenience import logic would end up
While the convenience names of e.g.
We fix this by removing those convenience imports; now, a user needs
Pull request is still work-in-progress; while it's possible I didn't make any mistakes, this is at this point untested. I opened a PR at this point in development just to get CI to run.
OK, I've now tested that it indeed solves the intended problem in Zulip with this 2-commit branch: https://github.com/timabbott/zulip/tree/pika-testing; with that, importing pika is just 35ms on my system.
timabbott/zulip@014c261 is the part of that PR that is the migration for this change; the other commit is just reverting the hack I'd added to work around this issue in Zulip.
Still haven't seen whether CI passes here, so I'm leaving the WIP tag on this PR.