Use socket_timeout from parameters as connection timeout #180

merged 1 commit into from Oct 2, 2012


None yet
2 participants

Pankrat commented Oct 2, 2012

Setting socket timeouts in Pika is a little bit confusing. Especially overriding the default connection timeout (250ms for blocking connections) involves subclassing the BlockingConnection to set the class attribute.

This patch removes the SOCKET_TIMEOUT class attribute which was only used for setting the initial connection timeout and instead reuses the already available socket_timeout from the connection parameters.

It also allows float values for retry_delay.

@Pankrat Pankrat Use socket_timeout for connection attempts
- Allow float value for retry_delay
- Remove unused SOCKET_TIMEOUT from adapters

gmr commented Oct 2, 2012

Thanks for the change (and the test!)

@gmr gmr pushed a commit that referenced this pull request Oct 2, 2012

Gavin M. Roy Merge pull request #180 from Pankrat/master
Use socket_timeout from parameters as connection timeout

@gmr gmr merged commit 8e5f870 into pika:master Oct 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment