New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PR #923 #924

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@lukebakken
Contributor

lukebakken commented Jan 18, 2018

Incorporates #923 with one change.

See #923

Fixes #921

aolefira and others added some commits Jan 18, 2018

@lukebakken lukebakken added this to the 0.12.0 milestone Jan 18, 2018

@lukebakken lukebakken self-assigned this Jan 18, 2018

@lukebakken lukebakken requested a review from michaelklishin Jan 18, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 18, 2018

Codecov Report

Merging #924 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files          21       21           
  Lines        3776     3776           
  Branches      560      560           
=======================================
  Hits         3101     3101           
  Misses        517      517           
  Partials      158      158
Impacted Files Coverage Δ
pika/adapters/libev_connection.py 73.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6638774...3580e5b. Read the comment docs.

@hugovk

This comment has been minimized.

Contributor

hugovk commented Jan 30, 2018

@lukebakken

This comment has been minimized.

Contributor

lukebakken commented Jan 30, 2018

@hugovk - we would be happy to review a pull request with that change.

@hugovk hugovk referenced this pull request Jan 30, 2018

Merged

Test on Python 3.7-dev #934

@hugovk

This comment has been minimized.

Contributor

hugovk commented Jan 30, 2018

@lukebakken Sure, there you go! #934

@michaelklishin michaelklishin merged commit ef157cb into master Jan 30, 2018

6 checks passed

codecov/patch 100% of diff hit (target 82.12%)
Details
codecov/project 82.12% (+0%) compared to 6638774
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukebakken lukebakken deleted the issue-921-lrb branch Jan 30, 2018

lukebakken added a commit that referenced this pull request Apr 12, 2018

Merge pull request #924 from pika/issue-921-lrb
Merge PR #923

(cherry picked from commit ef157cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment