New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pipeline updates #937

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@gmr
Member

gmr commented Jan 30, 2018

  • Drops testing support for Python 2.6
  • Moves to the build stages setup for travis
  • Builds combined coverage across all Python versions and uploads it to codecov
  • Adds testing of pypy and pypy3

@gmr gmr requested a review from lukebakken Jan 30, 2018

- python: 2.7
- python: 3.4
- python: 3.5
- python: 3.6

This comment has been minimized.

@lukebakken

lukebakken Jan 30, 2018

Contributor

Should 3.7-dev be included as well as in #934?

This comment has been minimized.

@gmr

gmr Jan 30, 2018

Member

I'd like to merge this as something atomic that works. I don't know what will or will not break in 3.7 and I'd rather get us to a baseline before tackling any 3.7 specific changes.

#934 should rebase based upon this add add a 3.7-dev version in IMO.

@lukebakken lukebakken referenced this pull request Jan 30, 2018

Merged

Test on Python 3.7-dev #934

@lukebakken lukebakken added this to the 1.0.0 milestone Jan 30, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 30, 2018

Codecov Report

Merging #937 into master will decrease coverage by 2.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #937     +/-   ##
=========================================
- Coverage   82.12%   79.52%   -2.6%     
=========================================
  Files          21       21             
  Lines        3776     3776             
  Branches      560      560             
=========================================
- Hits         3101     3003     -98     
- Misses        517      626    +109     
+ Partials      158      147     -11
Impacted Files Coverage Δ
pika/adapters/libev_connection.py 0.78% <0%> (-72.66%) ⬇️
pika/__init__.py 78.94% <0%> (-21.06%) ⬇️
pika/adapters/blocking_connection.py 84.74% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef157cb...06f294c. Read the comment docs.

@gmr gmr merged commit 44ff74f into master Jan 30, 2018

5 of 6 checks passed

codecov/project 79.52% (-2.6%) compared to ef157cb
Details
codecov/patch Coverage not affected when comparing ef157cb...06f294c
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gmr gmr deleted the build-changes branch Jan 30, 2018

@hugovk

This comment has been minimized.

Contributor

hugovk commented Jan 31, 2018

The coverage build job fails on PRs (eg. #933) and forks because:

0.54s$ aws s3 cp --recursive s3://com-gavinroy-travis/pika/$TRAVIS_BUILD_NUMBER/ coverage
fatal error: Unable to locate credentials

This should be disabled from PRs and forks.

@gmr

This comment has been minimized.

Member

gmr commented Jan 31, 2018

EDIT: So it looks like the PR job is run against your repo and it can't submit coverage. I'll add a condition to the job for now, but need to figure out a better way to handle it.

lukebakken added a commit that referenced this pull request Apr 12, 2018

Merge pull request #937 from pika/build-changes
Build pipeline updates

(cherry picked from commit 44ff74f)

lukebakken added a commit to lukebakken/pika that referenced this pull request Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment