New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libvev support #938

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@gmr
Member

gmr commented Jan 30, 2018

libev has not been updated since 2013 and is not maintaining support for Python versions greater than 3.3.

@gmr gmr requested a review from lukebakken Jan 30, 2018

@gmr gmr added this to the 1.0.0 milestone Jan 30, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 30, 2018

Codecov Report

Merging #938 into master will increase coverage by 2.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   79.52%   82.26%   +2.73%     
==========================================
  Files          21       20       -1     
  Lines        3776     3643     -133     
  Branches      560      541      -19     
==========================================
- Hits         3003     2997       -6     
+ Misses        626      499     -127     
  Partials      147      147
Impacted Files Coverage Δ
pika/__init__.py 77.77% <ø> (-1.17%) ⬇️
pika/adapters/__init__.py 72.22% <100%> (-5.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ff74f...758e0e9. Read the comment docs.

@gmr gmr merged commit 03275ed into master Jan 30, 2018

6 checks passed

codecov/patch 100% of diff hit (target 79.52%)
Details
codecov/project 82.26% (+2.73%) compared to 44ff74f
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gmr gmr deleted the remove-libev branch Jan 30, 2018

lukebakken added a commit that referenced this pull request Apr 12, 2018

Merge pull request #938 from pika/remove-libev
Remove libvev support

(cherry picked from commit 03275ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment