Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement add_callback_threadsafe in all connection adapters #956
(NOTE that the failed coverage test results from pika's encrypted credentials configuration issue)
This pull request implements a new method
Lack of this feature has been a pain point for users of
For example, this feature facilitates the app to delegate long-lasting processing of incoming messages to a background thread and then use
ADDITIONAL INFO FOR CHANGELOG: It is customary among frameworks - such as tornado, twisted, and asyncio - to designate a single threadsafe method that accepts a callback to be executed in the IOLoop's thread, and no others are thread-safe for ease of support/maintenance and for API orthogonality. Following this rationale, I removed the thread-safe designation inside the docstring of the ioloop
changed the title from
DO NOT MERGE Implement thread-safe IOLoop.add_callback
DO NOT MERGE Implement thread-safe add_callback
Feb 14, 2018
Regarding the coverage test failure, my guess below may be well off the mark but I'd try.
The credential is given here in .travis.yml
However, https://docs.travis-ci.com/user/encryption-keys/ has this to say:
That is why the credential is not available in the above build?
@shinji-s, thank you for looking into this. Your assessment makes a ton of sense. If that's the case, then the selected mechanism is inappropriate for the project's needs, since most 3rd-party PRs would naturally come from forks and reviewers as well as contributors need practical means to assess impact of those PRs on code coverage.