Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat is spammed with "gps started" and "destination reached" when doing a quest. #9

Closed
nuttapillar opened this issue Jul 15, 2022 · 11 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@nuttapillar
Copy link

image
Starting a quest causes "gps started" to continuously applear in chat until the destination is reached. Then it starts spamming "destination reached".
quest.txt
I have attaached the data for a quest that causes this issue in my server

@PikaMug
Copy link
Owner

PikaMug commented Jul 15, 2022

Thanks for the report. Please note that those messages are from GPS (not Quests or GPS-Quests) so all I can do is try to reduce their frequency.

I wasn't able to replicate this using your quest (for which I had to remove the start/finish actions since they weren't included), but looking at your screenshot this appears to be a duplicate of #8 which I wasn't able to replicate either.

Could you kindly reply with the following?:

  • Version number of Quests
  • Version number of GPS
  • Version number of GPS-Quests
  • Version number of QuestsBar

@nuttapillar
Copy link
Author

Quests 4.5.1, Im unsure of GPS version, as I was given a download link when I bought it about a week ago. So pretty recent, GPS Quests 1.8, QuestsBar is 1.6

@PikaMug
Copy link
Owner

PikaMug commented Jul 16, 2022

Please use /gpsa info to get the GPS version.

@nuttapillar
Copy link
Author

2.19.22

@nuttapillar
Copy link
Author

Hello, is there any update? Players on my server are getting annoyed with the message spam. They can't do quests in peace.

@nuttapillar
Copy link
Author

It only seems to be happening on quests that require the player to go to a given area. The message spams until the player gets there, then it stops. So basically as long as they are in a stage with a required location, it seems.

@PikaMug
Copy link
Owner

PikaMug commented Jul 18, 2022

I still haven't been able to replicate this. For the time being, consider asking the GPS developer if there's a way to disable those messages.

@nuttapillar
Copy link
Author

Oh, this might help: It only shows up for non-op/non-admin players it seems. I can't replicate it either as server owner, but when I join with an alt account and start the quest, it shows up.

@ghost
Copy link

ghost commented Sep 13, 2022

Yeah I have the exact same issue.

Using:

  • Quests v4.5.3
  • QuestsBar v1.7
  • QuestsGUI v0.48
  • GPSQuests v1.8
  • GPS v2.19.23

The Quest

  custom5:
    name: Q005
    ask-message: Go up on the mountain. Look for the light.
    finish-message: Good job! Here's 200$
    npc-giver-uuid: 1e99c552-091c-4e8f-8ada-aca3ebd6c746
    stages:
      ordered:
        '1':
          locations-to-reach:
          - 5FEM 157.0 103.0 -236.0
          reach-location-radii:
          - 5
          reach-location-names:
          - Up on the mountain
          start-message: Go towards the light on the mountain!
    rewards:
      money: 200
      exp: 250
    planner:
      cooldown: 300

How it looks in chat
https://i.imgur.com/qJOlLbH.png

My permissions (given to default group)
https://i.imgur.com/pmOydMm.png

Reproducing

  1. Create a quest
  2. Set a location block
  3. Save and close the quest editor
  4. Do the /questadmin reload
  5. Make sure you're a normal user. That your user is de-op'd.
  6. This only appears when using a NON-OP user.
  7. Take the quest
  8. Watch the GPS Started! error repeat over and over.

It's very reproducible on my end. It only happens when the user taking the quest is a default / non-OP user.

@PikaMug
Copy link
Owner

PikaMug commented Sep 14, 2022

Confirmed this occurs only on non-OP users or those without * permission. Looking into it.

@PikaMug PikaMug added bug Something isn't working duplicate This issue or pull request already exists labels Sep 14, 2022
@PikaMug
Copy link
Owner

PikaMug commented Sep 16, 2022

Version 1.9 resolves the duplicate "started" messages, although "destination" ones may still occur.

@PikaMug PikaMug closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants