quick alias code cleanup #914
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/6vdrcsovq |
FredKSchott
force-pushed
the
quick-alias-cleanup
branch
from
b767548
to
486af38
Compare
FredKSchott
force-pushed
the
quick-alias-cleanup
branch
from
486af38
to
9797935
Compare
| foundType = 'package'; | ||
| } | ||
| } else { | ||
| if (spec.startsWith(from)) { |
There was a problem hiding this comment.
lgtm, I also think this is unnecessary since it lead to abc/aa match alias { ab: './src' }.
There was a problem hiding this comment.
+1, the same logic now applies to both. I think the reason you weren't able to do this before was that path aliases end with / already, but package aliases do not, so this was a good chance to be explicit in this function.
There was a problem hiding this comment.
my bad，i forgot the from has added / for relative alias.
There was a problem hiding this comment.
np! I forgot too, took me a few tries to get this right
FredKSchott
force-pushed
the
quick-alias-cleanup
branch
from
9797935
to
14b6460
Compare
FredKSchott
force-pushed
the
quick-alias-cleanup
branch
from
14b6460
to
6d8fc02
Compare
| let foundType: 'package' | 'path' = isPackageAliasEntry(to) ? 'package' : 'path'; | ||
| const isExactMatch = spec === removeTrailingSlash(from); | ||
| const isDeepMatch = spec.startsWith(addTrailingSlash(from)); | ||
| if (isExactMatch || isDeepMatch) { |
There was a problem hiding this comment.
👍🏻 nice cleanup here. I’m finding this much easier to follow.
Changes
Testing
Covered by existing tests (and test added in #890)