Make the build reproducible #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] we noticed that pikepdf could not be built reproducibly. This is due to the .cpp input files were compiled/linked in an order that was determined by their layout on the filesystem which is, alas, non-deterministic. This was originally filed in Debian as #950138 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/950138
…tion to avoid non-determinstic memory addresses in the output Whilst working on the Reproducible Builds effort [0] we noticed that pikepdf could not be built reproducibly. The documentation included tutorial/walthrough-like output like so: <PIL.JpegImagePlugin.JpegImageFile image mode=RGB size=1000x1520 at 0x7F04BAC72B90> … where the "0x7F04BAC72B90" part is non-determinstic and thus varies between builds. This was originally filed in Debian as #950138 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/950138
|
Thanks. I suggest applying your |
lamby
added a commit
to lamby/python_example
that referenced
this pull request
Feb 8, 2020
…egardless of filesystem ordering. re. pikepdf/pikepdf#76
|
Sure thing, I have now done so — thanks for the suggestion. |
tasmo
pushed a commit
to prototypefund/reproducible-website
that referenced
this pull request
Apr 24, 2020
wjakob
pushed a commit
to pybind/python_example
that referenced
this pull request
Apr 26, 2020
…egardless of filesystem ordering. re. pikepdf/pikepdf#76
wjakob
pushed a commit
to pybind/python_example
that referenced
this pull request
Apr 26, 2020
…egardless of filesystem ordering. re. pikepdf/pikepdf#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort I noticed that pikepdf could not be built reproducibly. This was due to two reasons:
a) The documentation included tutorial/walthrough like output like so:
… where the
0x7F04BAC72B90part is non-determinstic and thus varies between builds.b) The
.cppinput files were compiled/linked in an order that was determined by their layout on the filesystem which is, at least on UNIX systems, non-deterministic.This PR addresses both these issues.
It was orginally filed in Debian as #950138.