secure check #15

Closed
michaelwittig opened this Issue Sep 13, 2012 · 3 comments

Comments

Projects
None yet
4 participants
Contributor

michaelwittig commented Sep 13, 2012

hi.

I have a problem with line 49 in lib/cookies.js:
if (!secure && opts && opts.secure) throw new Error("Cannot send secure cookie over unencrypted socket")

my node workers run in http mode because i handle SSL with stunnel before the requests enter haproxy where they are routed to my machines.

Are you happy with an option called secureProxy or something like this?

Contributor

jed commented Sep 13, 2012

sure, that sounds reasonable.

jed closed this Nov 26, 2012

I think this option should be called "force secure", as the library is not doing anything to determine if you are behind a proxy.

Contributor

dougwilson commented Jun 10, 2015

Hi @robertjd , as this issue is from about 3 years ago, it's considered stale and archived. Please open a new issue if it's still an issue for you!

dougwilson locked and limited conversation to collaborators Jun 10, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.