Fix express cookie duplication #18

Merged
merged 2 commits into from Nov 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

mtkopone commented Nov 12, 2012

No description provided.

mtkopone added some commits Nov 12, 2012

@mtkopone mtkopone Remove unused var e0170cf
@mtkopone mtkopone Fix multiple set cookie calls duplicating cookies
Express/Connect has an override of res.setHeader, which has special handling for 'Set-Cookie'. This causes all already added cookies to get duplicated.

Fix by checking if we're under express/connect, and then behaving appropriately.
f8cbb1f

@jed jed added a commit that referenced this pull request Nov 12, 2012

@jed jed Merge pull request #18 from mtkopone/fix-express-cookie-duplication
Fix express cookie duplication
19985ed

@jed jed merged commit 19985ed into pillarjs:master Nov 12, 2012

1 check passed

default The Travis build passed
Details
Contributor

jed commented Nov 12, 2012

thanks, @mtkopone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment