Reverse proxy support for configuration saving #91

Closed
DamnDam opened this Issue Oct 25, 2013 · 6 comments

Projects

None yet

2 participants

@DamnDam
DamnDam commented Oct 25, 2013

This issue completes #65

Reverse proxy works great in 0.45, but the configuration cannot be saved when accessing through the proxy.
On the configuration page, the 'saveconfig' post call should be prefixed with the reverse proxy directory.

@DamnDam
DamnDam commented Oct 25, 2013

For example, on my installation, I solved this by hardcoding the reverse proxy prefix here :

templates/config.html#L389

$.post($SCRIPT_ROOT + "/revproxy/saveconfig", $("#cfgform").serialize(),
@pillone
Owner
pillone commented Oct 25, 2013

thanks for the report.

fixed in the 0.46RC_bugfix branch

@DamnDam
DamnDam commented Oct 25, 2013

Thank you =)

@DamnDam
DamnDam commented Oct 26, 2013

Hmm.. This is not fully OK.

In case you set up a wrong revproxy, you are definitely prevented from saving the configuration ever.

Bug replication :

  • Set the revproxy to '/foo' in the config page.
  • Save
  • Reload the config page
    -> Saving in now broken

IMHO, revproxy setting should be banned from the config page and be loaded from a configuration file on startup only.

@pillone
Owner
pillone commented Oct 26, 2013

thanks,

it is not easy to bring this functionality decently without having a rev proxy setup.
It is basically based on user patches..

I fix this

@DamnDam
DamnDam commented Nov 13, 2013

Perfect !
Thank you for your work.

@DamnDam DamnDam closed this Nov 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment