New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse proxy support for configuration saving #91

Closed
DamnDam opened this Issue Oct 25, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@DamnDam

DamnDam commented Oct 25, 2013

This issue completes #65

Reverse proxy works great in 0.45, but the configuration cannot be saved when accessing through the proxy.
On the configuration page, the 'saveconfig' post call should be prefixed with the reverse proxy directory.

@DamnDam

This comment has been minimized.

Show comment
Hide comment
@DamnDam

DamnDam Oct 25, 2013

For example, on my installation, I solved this by hardcoding the reverse proxy prefix here :

templates/config.html#L389

$.post($SCRIPT_ROOT + "/revproxy/saveconfig", $("#cfgform").serialize(),

DamnDam commented Oct 25, 2013

For example, on my installation, I solved this by hardcoding the reverse proxy prefix here :

templates/config.html#L389

$.post($SCRIPT_ROOT + "/revproxy/saveconfig", $("#cfgform").serialize(),
@pillone

This comment has been minimized.

Show comment
Hide comment
@pillone

pillone Oct 25, 2013

Owner

thanks for the report.

fixed in the 0.46RC_bugfix branch

Owner

pillone commented Oct 25, 2013

thanks for the report.

fixed in the 0.46RC_bugfix branch

@DamnDam

This comment has been minimized.

Show comment
Hide comment
@DamnDam

DamnDam Oct 25, 2013

Thank you =)

DamnDam commented Oct 25, 2013

Thank you =)

@DamnDam

This comment has been minimized.

Show comment
Hide comment
@DamnDam

DamnDam Oct 26, 2013

Hmm.. This is not fully OK.

In case you set up a wrong revproxy, you are definitely prevented from saving the configuration ever.

Bug replication :

  • Set the revproxy to '/foo' in the config page.
  • Save
  • Reload the config page
    -> Saving in now broken

IMHO, revproxy setting should be banned from the config page and be loaded from a configuration file on startup only.

DamnDam commented Oct 26, 2013

Hmm.. This is not fully OK.

In case you set up a wrong revproxy, you are definitely prevented from saving the configuration ever.

Bug replication :

  • Set the revproxy to '/foo' in the config page.
  • Save
  • Reload the config page
    -> Saving in now broken

IMHO, revproxy setting should be banned from the config page and be loaded from a configuration file on startup only.

@pillone

This comment has been minimized.

Show comment
Hide comment
@pillone

pillone Oct 26, 2013

Owner

thanks,

it is not easy to bring this functionality decently without having a rev proxy setup.
It is basically based on user patches..

I fix this

Owner

pillone commented Oct 26, 2013

thanks,

it is not easy to bring this functionality decently without having a rev proxy setup.
It is basically based on user patches..

I fix this

@DamnDam

This comment has been minimized.

Show comment
Hide comment
@DamnDam

DamnDam Nov 13, 2013

Perfect !
Thank you for your work.

DamnDam commented Nov 13, 2013

Perfect !
Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment