Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Remove frame argument from Range() queries. #1358

Merged

Conversation

travisturner
Copy link
Member

Overview

This PR removes the frame argument from Range() queries, so instead of Range(frame=f, f > 10) the query would be Range(f > 10).

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

@@ -600,8 +591,8 @@ func (e *Executor) executeTopNSlice(ctx context.Context, index string, c *pql.Ca
N: int(n),
Src: src,
RowIDs: rowIDs,
FilterName: field,
FilterValues: filters,
FilterName: attrName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep these old names here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily. I thought I would leave them until we decided that attrName was good.

Copy link
Contributor

@alanbernstein alanbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@travisturner travisturner merged commit 3023d6f into FeatureBaseDB:develop Jun 5, 2018
@travisturner travisturner deleted the rename-field-part-three branch June 5, 2018 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants