Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

More messaging simplification #1391

Merged
merged 2 commits into from Jun 19, 2018
Merged

More messaging simplification #1391

merged 2 commits into from Jun 19, 2018

Conversation

jaffee
Copy link
Member

@jaffee jaffee commented Jun 19, 2018

Overview

check out the individual commits

Fixes #

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

@jaffee jaffee requested a review from codysoyland June 19, 2018 16:56
codysoyland
codysoyland previously approved these changes Jun 19, 2018
NewServer calls LoadNodeID, and NopBroadcaster and NopBroadcastReceiver are
already set up as the defaults.
@jaffee jaffee merged commit 1103039 into develop Jun 19, 2018
@jaffee jaffee deleted the more-messaging-simplification branch June 19, 2018 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants