Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

made web-app-theme rails 3.1 compatible #40

Open
wants to merge 16 commits into from

4 participants

@nathanvda

I made sure web-app-theme works with rails 3.0 and rails 3.1. Furthermore I fixed the specs so the generators are tested more. I did not check the cucumber features.

@simonmd

Excellent! when would this be merged?

@rgabo rgabo referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@rgabo

@nathanvda, can you please rebase it to 0.7.0. Your fork does not contain Activo 2 theme and it will also be easier for @pilu to pull. I've done this for ourselves in our fork, but I'm sure others would love to point your Gemfile's to your fork until it gets pulled into an official version.

@rgabo rgabo referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@rgabo rgabo referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@rgabo rgabo referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@nathanvda

I had some troubles getting the default (activo-2) working correctly. I got it to work (without needing to edit any stylesheet) if i copied the images and fonts (under stylesheets) to app/assets/images. Not sure if this is the wanted approach, but this way at least is the easiest to maintain backward compatibility.

@rgabo

The 'problem' is that the default JS and CSS assets are combined into application.js and application.css in Rails 3.1, so any relative paths will be relative to that, even if they were originally pulled in by Sprockets from a subdirectory by require_tree .. I think in many cases (such as internal applications), pulling in web-app-theme separate from the combined assets is fine, but it needs changes to the default application.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 18, 2011
  1. @nathanvda
  2. @nathanvda
  3. @nathanvda
Commits on Jul 20, 2011
  1. @nathanvda

    Ignore unneeded files.

    nathanvda authored
  2. @nathanvda
  3. @nathanvda

    Simplified a bit.

    nathanvda authored
  4. @nathanvda
Commits on Aug 9, 2011
  1. @nathanvda
  2. @nathanvda
  3. @nathanvda
  4. @nathanvda
Commits on Aug 24, 2011
  1. @coupacooke

    Changed to use spec files

    coupacooke authored
Commits on Aug 25, 2011
  1. @nathanvda

    Merge pull request #1 from coupacooke/patch-1

    nathanvda authored
    Fixed test directory references
Commits on Aug 27, 2011
  1. @nathanvda
Commits on Aug 28, 2011
  1. @nathanvda
  2. @nathanvda

    Make sure that the images/fonts are copied so that they can be picked…

    nathanvda authored
    … up correctly in rails3.1 (without having to edit the stylesheets).
Something went wrong with that request. Please try again.