Symfony7 next steps

[herbertroth]

This pull request makes several improvements to command registration and code consistency, as well as updates to GraphQL type classes for dependency injection. The most significant changes are the migration to Symfony's attribute-based command registration, explicit return type declarations, and the replacement of Symfony's dependency injection interfaces with Pimcore's equivalents in GraphQL type classes.

Command Registration and Configuration

• Migrated command registration in MigrateLegacyConfig and RebuildWorkspacesCommand from method-based configuration to the Symfony AsCommand attribute, simplifying command definitions. [1] [2]
• Removed legacy configuration code from the configure() methods in both command classes, as configuration is now handled by attributes. [1] [2]

Code Consistency and Type Safety

• Updated the execute methods in both command classes to explicitly declare int as the return type, aligning with Symfony standards and improving type safety. [1] [2]
• In ConfigController, replaced direct request parameter access with ParameterBagHelper::getInt for safer integer retrieval.

Dependency Injection in GraphQL Types

• Replaced usage of Symfony\Component\DependencyInjection\ContainerAwareInterface and ContainerAwareTrait with Pimcore's equivalents (Pimcore\Bundle\CoreBundle\DependencyInjection\ContainerAwareInterface and ContainerAwareTrait) across multiple GraphQL type classes for consistency within the Pimcore codebase. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
• Removed redundant property declarations for $container in DocumentElementType, as the trait now handles this.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud