Skip to content

Add CSRF protection for Add to cart action #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Add CSRF protection for Add to cart action #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0fb548
Fix CSRF protection for cart - resolves #260
dvesh3 Dec 9, 2021
1db78cc
Fix CSRF protection for cart - resolves #260
dvesh3 Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Controller/CartController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ protected function getCart()
}

/**
* @Route("/cart/add-to-cart", name="shop-add-to-cart")
* @Route("/cart/add-to-cart", name="shop-add-to-cart", methods={"POST"})
*
* @param Request $request
* @param Factory $ecommerceFactory
Expand All @@ -65,6 +65,10 @@ protected function getCart()
*/
public function addToCartAction(Request $request, Factory $ecommerceFactory)
{
if (!$this->isCsrfTokenValid('addToCart', $request->get('_csrf_token'))) {
throw new \Exception('Invalid request');
}

$id = $request->get('id');
$product = AbstractProduct::getById($id);

Expand Down
7 changes: 5 additions & 2 deletions templates/product/detail.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,11 @@
<p class="small text-muted mt-1">{{ 'general.available-in' | trans }} {{ ('attribute.' ~ product.saleInformation.saleInformation.availabilityType) | lower | trans }}</p>
{% endif %}
</div>

<a href="{{ path('shop-add-to-cart', { id: product.id }) }}" class="btn btn-success btn-block">{{ 'general.add-to-cart' | trans }}</a>
<form id="shop_add_to_cart_form" method="post" action="{{ path('shop-add-to-cart', { id: product.id }) }}">
<input type="hidden" name="_csrf_token" value="{{ csrf_token('addToCart') }}">
<a href="#" onclick="document.getElementById('shop_add_to_cart_form').submit();"
class="btn btn-success btn-block">{{ 'general.add-to-cart' | trans }}</a>
</form>

</div>

Expand Down
7 changes: 6 additions & 1 deletion templates/product/product_teaser.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@
</a>
</div>
<div class="col p-1">
<a href="{{ path('shop-add-to-cart', { id: product.id }) }}" class="btn btn-block btn-primary">{{ 'general.buy' | trans }} <i class=" ml-2"><img src="/static/images/icons/cart.svg" height="20" width="auto"></i></a>
<form id="shop_add_to_cart_form" method="post" action="{{ path('shop-add-to-cart', { id: product.id }) }}">
<input type="hidden" name="_csrf_token" value="{{ csrf_token('addToCart') }}">
<a href="#" onclick="document.getElementById('shop_add_to_cart_form').submit();"
class="btn btn-block btn-primary">{{ 'general.buy' | trans }} <i class=" ml-2"><img
src="/static/images/icons/cart.svg" height="20" width="auto"></i></a>
</form>
</div>
</div>
</div>
Expand Down